Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add default value to custom nonce modal #28659

Merged
merged 2 commits into from
Nov 25, 2024
Merged

fix: Add default value to custom nonce modal #28659

merged 2 commits into from
Nov 25, 2024

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Nov 22, 2024 •
edited by github-actions bot
Loading

Description

See original bug ticket.

Open in GitHub Codespaces

Related issues

Fixes: #28033

Manual testing steps

See original bug ticket.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Nov 22, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Nov 22, 2024
@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner November 22, 2024 17:49
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [0a158b5]
Page Load Metrics (2165 ± 141 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint43327982062470226
domContentLoaded181027892123293141
load182127962165294141
domInteractive27392667938
backgroundConnect12104402613
firstReactRender914251426933
getState577242412
initialActions01000
loadScripts128922021569260125
setupStore77915178
uiStartup204836032437395190
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 4 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [a97d2d0]
Page Load Metrics (1696 ± 72 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15442030171814570
domContentLoaded15001910164511857
load15332037169614972
domInteractive16196444019
backgroundConnect12379568139
firstReactRender59133922110
getState469252211
initialActions00000
loadScripts1082137912089344
setupStore5549105
uiStartup16872441188819393
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 4 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Nov 25, 2024
Merged via the queue into develop with commit b7fa3fa Nov 25, 2024
75 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/28033 branch November 25, 2024 13:53
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@digiwand digiwand digiwand approved these changes

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

Assignees

@pedronfigueiredo pedronfigueiredo

Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
4 participants
@pedronfigueiredo @metamaskbot @matthewwalsh0 @digiwand